Page Comparison

General updates

• JW – Some confusion on docs examples link, I’ve redirected RTD to latest temporarily

Things to review

• OE license security for PRs from forks

  • JM – Playground for “Trusted user posts a special GH comment that allows CI on the latest commit to have access to secrets”

  • Github link macro
    link https://github.com/Yoshanuikabundi/secrets_testing

  • JM – Generally, this would be possible, but we’d either need to

    • duplicate all the CI yamls to have trusted and untrusted variants, or

    • Add ~100 lines to each CI yaml to add trust-detection logic

  • So basically, it’s not possible to have an external file that can just be added to repos to make a “magic word” for maintainers to allow CI secret access to previous commit.

• Decision – After one research cycle on this, we’ve decided not to try rolling our own privileged/fine-grained secrets access for PRs from forks. Instead, when people open a new PR to master, a maintainer will make a new branch (like contrib-987) off master, redirect the PR to that, expect that secrets-requiring CI will fail, merge the PR into contrib-987, then the maintainer will open a PR from contrib-987 into master and merge if CI passes.

Next steps

• (low priority) JM will make a checklist for the above “PR from forks” process for openff-toolkit wiki

• (medium) JM will advertise openff-toolkit-examples package on #internal slack channel

• (high) Users guides

  • Continuing Interchange user guide – Figuring out where to meet in the middle

    • Github link macro
      link https://github.com/openforcefield/openff-interchange/pull/309

    • JM – Bullet points could be good. Prepared talks are also really good – What’s the philosophy behind the thing? What do the examples highlight? Etc. The most important part is the “why?” and the “what?”, whereas the “how” can be looked up in the API docs

  • Bespokefit/QCSubmit docs – Same as above

    • JM – There are talks on this on Youtube, maybe I can craft something from that?

    • JW – It’d be cool if you can harvest the high-level points from those, but I’ll also tell JHorton and/or SBoothroyd to get in contact with you once they’re ready to begin iterating on this.

• (low) Check main website for broken links

• (medium) Spec migration PR

  Github link macro
  link https://github.com/openforcefield/openff-toolkit/pull/949

  • (Discussed steps forward at length, came up with a plan in a comment on that PR)