2022-04-18 Core Developers meeting notes

Participants

  • @Pavan Behara

  • @David Dotson

  • @Chapin Cavender

  • @Matt Thompson

  • @Jeffrey Wagner

  • @Simon Boothroyd

Discussion topics

Item

Notes

Item

Notes

Individual updates

  • CC

  • MT

    • Backporting/forwardporting PRs between biopolymer-topology-refactor and master branches in Toolkit. So all PRs into master got forwardported, expected it to take days, instead just took hours. Pleasantly surprised.

    • Interchange regression tests

      • Did a lot of digging to learn that 200-300 failing single-molecule charge assignment comparisons were failing because of trans-cooh behavior in OpenEye wrapper. Ported this fix into the other branch and then only 30-40 molecules are failing (max partial charge on any atom deviation between 1e-6 and 1e-2). Really hard to isolate these last few. JW looked at this and the SMILES used an aromaticity model other than MDL, which may have led to it being interpreted oddly. Possible it’s due to duplicates in the dataset, hashing+caching, runtime non-determinism, or aromaticity issue above.

        • CC – It sounds like this is all OE - Do you see similar discrepancies in AmberTools?

        • MT – We’re just testing OE (since it’s fast enough to go through this industry benchmark set). OE is also more straightforward - It’s a single library to assign charges, rather than relying on the combined behaviors of RDKit and AmberTools. So this route prioritizes finding bugs in Interchange and the Toolkit rather than the external libraries.

      • Condensed phase tests - Did these tests a while ago. Didn’t see any differences. This was a little bit surprising since the single-molecule tests showed differences. But I looked again and there were no COOHs in the condensed phase work.

      • Value propagation tests - Looking good

      • WBO tests - Looking good

      • Vsites - Depends on SB refactor getting merged

    • JMitchell has been working on interchange docs for much of the last two weeks - Made a big set of changes to user guide. Last week he finished overhauling examples, and they’re in a much better state now. I’m really happy witht he state of Interchange docs now.

    •  

    •  

  • DD

    • Protein-ligand benchmarks

    • QCArchive

      • still working on getting openff-qcsubmit ( ) into shape for QCFractal next

      • will drive to get this out this week; aiming to get a submission out via qca-dataset-submission-next-test

      • waiting for response from Bert de Groot on MPI cluster account; will try again this week

  • PB

    • Worked on FFR update on fitting experiments, and planning out things to do with Trevor. Valence parameter improvements

    • Have to work on Sage paper and blog post this week.

  • JW –

    • Worked half days Mon+Tues

    • Good amount of project-ish planning - Working on how we plan + communicate with OMSF and ad/gov boards.

    • Prioritizing vsite rework review and topology refactor

      • No longer checking numerical value of outOfPlaneAngle for DivalentLonePair to determine allowed values of match

        • SB – As the FF fitting user I’d prefer to compare the value numerically and get an error if the vsites are going to be basically on top of each other.

      • Enforcing correct length of charge_increment list for each vsite type (turns out one of my test scripts was feeding in lists of the incorrect length and the handler was fine with this)

    • SB – Timeline for 0.10.5?

      • JW – I’ll push to merge vsites today

      • MT – I can make relesae as soon as it’s merged.

      • JW – So plan on Tuesday release.

  • SB –

    • Been doing some vsite fitting. It’s super easy to see improvements on single molecules like pyridine. But whenw e try to do vsites on chemcical series (like larger molecules that include pyridine) then the improvement becomes a lot less clear. So it could be that comparing to electric potential at the level of detail we’re using isn’t sufficient to show improvement. Still need to look into why we’re not seeing improvement.

    • JW – Are BondCharges doing any better?

    • SB – Not sure - I’m seeing improvement for single molecules, but not when I try to generalize parameters (RMSE on larger sets doesn’t improve significantly).

    •  

Action items

Decisions