2022-03-16 Thompson/Wagner Check-in meeting notes

Participants

  • @Matt Thompson

  • @Jeffrey Wagner

Discussion topics

Item

Notes

Item

Notes

VSite tests

  • (JW sent to MT at beginning of meeting)

 

Plan for fixing up vsites

  • MT – This may take like two months to fix. Only you and I are able to fix that. How do we accomplish that?

  • MT – When I run the before- and after- tests, I get the same number of errors. I’m not sure if they’re the SAME errors though.

  • JW – So, that’s good

  • MT – If the FF team is sticking with the 0.10.X series, then future fitting experiments wouldn’t be helped by resolving these in the 0.11. series

  • JW – I still need to send 5 diverse molecules and OFFXMLs that assign vsites, for geometry+energy tests.

  • JW – There was strong support from the ad board to adding vsites to FFs. They said that they basically didn’t require proof of improvement, they already believe it will happen.

    • MT – I agree that proof isn’t needed. For now we’ll only give first class support to openmm, but other engines can follow.

    •  

  • JW – Seems to be three categories of error (note: we don’t need to solve these for the 0.11.0 release, we just can’t introduce new bugs):

    • A vsite can’t apply to atoms in DESCENDING topology order (eg, a bondcharge that should have atom 1 as its first parent, and atom 2 as its second, will instead flip them) (Toolkit issue open on this)

    • VSites that override earlier matches do NOT overwrite their chargeincrements, instead they seem to sum them.

    • Some (but not all) DivalentLonePair sites say that their permutations are impossible

  • MT – It’s not clear who is responsible for fixing this. It’s also not clear how much work the code changes will be. Trevor’s PR should not have tests expanded in scope, it should focus specifically on the reproducing case of its problem.

    • JW – I think trevor should do the PR. The timeline for the alpha and rc packages is uncertain, so there’s a good chance that I’ll have time to help.

    • MT – The bugfixes shouldn’t be required for 0.11.0. And we should be careful about inadvertently adding behavior changes/bugs during the alpha or rc periods.

    • JW – Agree, I’m more flexible about making changes during alpha or rc period, but I anticipate running the whole notebook before merging ang “bugfix” PRs to ensure that we’re not breaking things somewhere else. And agree that these bugfixes aren’t blockers to 0.11.0

Ad board update

(Pasted directly from ad board notes)

  • CBy – Are vsites going to be included in rosemary?

  • SB – My thinking is that there’s no major blocker to including them in Rosemary, IF they are ready. This depends both on the results of fitting, and our ability to export them to different formats.

    • CBy – Do we have to be “held hostage” by the lowest common denominator in FF engines? 

    • DM – My concern is partly what Chris said, and also downstream workflows. When you shift between systems with vsites and systems without vsites, you can cause a lot of damage. Like, just switching from TIP3P to TIP4P is quite a bit of work. So even if the engine-compatibility issue goes away, we still need to consider not breaking existing workflows. So my proposal would be that we consider making two variants - “Rosemary with vsites” and “Rosemary without vsites”. 

    • CBy – I think that’s a great idea. Would it be double the work to make two variants?

    • SB – I think it’s just a matter of compute, not human time. The real compute question is “how expensive are the biopolymer benchmarks?” If we only have enough compute power to do it once then we can’t make two FFs. I would stipulate that the period of time where we maintain two FF variants should be specified, and it should be short.

    • MS – Maintaining two force fields would take about 130% the human time of making+maintaining one.

    • DM – We’d probably need a period of overlap in order to do side-by-side testing and prove that the vsites are worth it

    •  

    • CBy – OPLS3 showed that vsites are worth it. Especially eg in binding FE calcs with pyridine nitrogens, and other places with lone-pair anisotropy. So is it really necessary to PROVE that we need vsites?

    • KM – We would use a FF with vsites, even if it requires more human time from us.

    • CS – What’s the alternative? To not do vsites at all? What would alternatively be done with the time?

    • DM – It’s true that we could go to vsites more directly without a lot of testing

    • MS – Bottleneck would be MThompson’s time in getting exporters set up

    • SB – The work that goes toward vsites would overlap substantially with going toward things like graph-based charge models. So we’re already putting in a similar amount of effort whether we do vsites or not. 

    •  

    • MS – One question is whether we prove-then-implement, or implement-then-prove?

    • MM – Sage is already fine. If people’s workflows can’t handle vsites then they still get to work with Sage.

    • CS – I’m also excited to get bespokefitting to work. 

    • MS – Does anyone on this call use CHARMM extensively? That’s one of the harder exporters to build

    •  

    • FP - YOLO on virtual sites -- but you'll need the data regardless before or after.

    • DC - I’ll take the chance to plug our preprint where we also find that vsites have big accuracy gains (in a different force field model): Exploration and Validation of Force Field Design Protocols through QM-to-MM Mapping

    •   

    •  JW – Opportunity cost of pursuing vsites now would be delaying polarizability support and refinement of small molecule benchmarking tools. 

    • GT – Early on when we were testing pmx with the folks in gottingen, vsites were clearly superior. I would advocate doing vsites before polarizability.

      • AN – Agree

      • FP – Agree

    • MS – I’d think at this point we could assemble a document showing which vsites we propose adding to start gathering feedback

      • SB – I’ll get a project page assembled in the next ~month.

    • DN – I’m somewhat concerned about how this affects the existing backlog, but I don’t fully understand the effects right now. 

      • JW – I’ll work with you to understand this, and will prioritize effort according to your direction. 

 

 

Action items

Decisions